input-bugfix-take-2: proper bugfix #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug introduced by #181, which was a bugfix for a bug reported in #180.
Before #181, when a non-zero
offinto the current input buffer was provided, the loop was conservative in what it would consume: rather than attempting to consume characters in the range[off, off + len), it would only consider the characters in the range[0, len).#181 changed this so that it considered the range
[off, idx + len)whereidxis the current position in the input buffer. This seemingly worked on simple parsers. However for more complex parsers this led to unsafe memory accesses when determining how much of the input to consume, and that resulted in a length that ran over the end of the input buffer. When antake_while*parser then tried to return the bytes to the user, a checked memory access would then fail.