consume: Add required consume argument to parse functions #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For oneshot parse functions, require that the caller specify whether the parser should consume all of the provided input or just a prefix. Most parsers are written so that they can consume the prefix of a string. This combined with the use of backtracking can cause unexpected parse results where only part of the input was consumed. This is one of many reasons to avoid backtracking. In any case, making the behavior explicit in the call will hopefully demistify some of these results.
|
Closes #183. |
seliopou
changed the title
seliopou
changed the title
|
The build is failing on OCaml 4.05.0 due to a timeout when running the following command: |
The solver keeps timing out trying to come up with a solution when installing angstrom-async and angstrom-lwt-unix packages. Could not reporduce locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For oneshot parse functions, require that the caller specify whether the parser should consume all of the provided input or just a prefix.
Most parsers are written so that they can consume the prefix of a string. This combined with the use of backtracking can cause unexpected parse results where only part of the input was consumed. This is one of many reasons to avoid backtracking.
In any case, making the behavior explicit in the call will hopefully demistify some of these results.