-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch-event substitutes for click-event #50
Merged
jyuunnii
merged 10 commits into
inhibitor1217:master
from
jyuunnii:feature/app/cafe-slide
Jan 21, 2021
Merged
Touch-event substitutes for click-event #50
jyuunnii
merged 10 commits into
inhibitor1217:master
from
jyuunnii:feature/app/cafe-slide
Jan 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Carousel division by dirction (row, column)
카페 정보를 나타내는 CafeDetail 컴포넌트를 현재 cafe !== null 이면 보여주는 식으로 컨트롤 하고 있는데,
|
- Responsive height - Theme color
- Add bottom dot : represent current index & total number of images - Delete prev, next sign on image
inhibitor1217
previously approved these changes
Jan 19, 2021
이것의 경우에는, 나중에 페이지 외부에서 카페 detail로 들어가는 링크 같은 걸 쏴주려면 라우터를 추가하는 것이 맞습니다. |
inhibitor1217
previously approved these changes
Jan 21, 2021
inhibitor1217
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
터치 슬라이드 기능 대체
사용 라이브러리: react-swipeable