Adding support for ZSTD compression in MyRocks

Summary: This diff optionally links ZSTD compression library. If not specified in build option, ZSTD is not linked and it doesn't stop with warnings/errors even if ZSTD does not exist. Differential Revision: https://reviews.facebook.net/D52107 fbshipit-source-id: 0512d8dba83
inikep · Sep 2, 2021 · 1c8f727 · 1c8f727
1 parent de5eb85
commit 1c8f727
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/mysql-test/suite/rocksdb/r/compression_zstd.result b/mysql-test/suite/rocksdb/r/compression_zstd.result
@@ -0,0 +1,2 @@
+create table t (id int primary key) engine=rocksdb;
+drop table t;
diff --git a/mysql-test/suite/rocksdb/t/compression_zstd-master.opt b/mysql-test/suite/rocksdb/t/compression_zstd-master.opt
@@ -0,0 +1 @@
+--rocksdb_default_cf_options=compression_per_level=kZSTDNotFinalCompression;compression_opts=-14:4:0
diff --git a/mysql-test/suite/rocksdb/t/compression_zstd.test b/mysql-test/suite/rocksdb/t/compression_zstd.test
@@ -0,0 +1,4 @@
+--source include/have_rocksdb.inc
+
+create table t (id int primary key) engine=rocksdb;
+drop table t;
diff --git a/storage/rocksdb/CMakeLists.txt b/storage/rocksdb/CMakeLists.txt
@@ -62,6 +62,12 @@ ELSE()
   SET(rocksdb_static_libs ${rocksdb_static_libs} bz2)
 ENDIF()
 
+# link ZSTD only if instructed
+IF (NOT "$ENV{WITH_ZSTD}" STREQUAL "")
+  SET(rocksdb_static_libs ${rocksdb_static_libs} $ENV{WITH_ZSTD}/lib/libzstd.a)
+  ADD_DEFINITIONS(-DZSTD)
+ENDIF()
+
 SET(rocksdb_static_libs ${rocksdb_static_libs} ${ZLIB_LIBRARY})
 
 MYSQL_ADD_PLUGIN(rocksdb_se ${ROCKSDB_SOURCES} STORAGE_ENGINE DEFAULT STATIC_ONLY