Removed double signing of apk file #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added addition check for "keystore_password" before trying to sign apk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added addition check for "keystore_password" before trying to sign apk
When building Xamarin.Android project with:
keystore_path
keystore_alias
keystore_password
provided, "SignAndroidPackage" target added automatically, which causing VisualStudio to build app, than sign with default Xamarin keystore, then "apksign_and_zipalign" sign it again.
This fix checking:
if keystore details are provided -> it will replace "SignAndroidPackage" with "Package" to generate apk, then "apksign_and_zipalign" sign apk with desired credentials.
if keystore details are NOT provided: "SignAndroidPackage" with be used to sign apk with Xamarin default credentials and "NO" "apksign_and_zipalign" will be called.