Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/refactor project name #27

Merged
merged 12 commits into from
Apr 10, 2023
Merged

Docs/refactor project name #27

merged 12 commits into from
Apr 10, 2023

Conversation

H4ppy-04
Copy link
Collaborator

@H4ppy-04 H4ppy-04 commented Apr 9, 2023 •
edited
Loading

Changes

  • cleaned up a few imports
  • Minor typing
  • small readability changes

@H4ppy-04 H4ppy-04 linked an issue Apr 9, 2023 that may be closed by this pull request
refactor old project name #26
Closed
2 tasks
@H4ppy-04 H4ppy-04 requested a review from initd1 April 9, 2023 12:36
initd1
initd1 requested changes Apr 9, 2023
View reviewed changes
Copy link
Owner

@initd1 initd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the email argument in mail.py needs to be changed from
breach_checker = EmailBreachChecker(args.ip) to
breach_checker = EmailBreachChecker(args.email)

main.py Outdated Show resolved Hide resolved
@initd1 initd1 added the documentation Improvements or additions to documentation label Apr 9, 2023
@H4ppy-04 H4ppy-04 requested a review from initd1 April 10, 2023 01:07
initd1
initd1 requested changes Apr 10, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@initd1
Copy link
Owner

initd1 commented Apr 10, 2023

I believe my #29 merge has caused the merge conflicts. I will have a look later today.

@H4ppy-04 H4ppy-04 requested a review from initd1 April 10, 2023 01:25
@initd1 initd1 merged commit 2912189 into main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@initd1 initd1 initd1 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor old project name
2 participants
@H4ppy-04 @initd1