Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker integration using Github CI Actions #48

Merged
merged 13 commits into from
Apr 16, 2023

Conversation

initd1
Copy link
Owner

@initd1 initd1 commented Apr 11, 2023

Docker integration using Github CI Actions

@initd1 initd1 added the feature Addition of feature label Apr 11, 2023
@initd1 initd1 self-assigned this Apr 11, 2023
@initd1 initd1 linked an issue Apr 11, 2023 that may be closed by this pull request
@initd1 initd1 linked an issue Apr 15, 2023 that may be closed by this pull request
initd1 and others added 5 commits April 15, 2023 18:12
* Create CONTRIBUTION.md (#51)

* Bug/error logging to terminal (#46)

* fixed bugs that prevented logger output to console

* code linting and formating

* fixed ip module terminal output
black-ified ✨ 🍰 ✨

* added docstrings, improved and consistent logging

---------

Co-authored-by: kash <kashvijayperth@gmail.com>

* Update README.md

updated sample output

* Update README.md

added CodeQL status badge

* Fixing bug that doesn't log to file (#53)

* initial commit to add file handler

* fixed file handler bug

* black-ified 💥 💔 💥

---------

Co-authored-by: kash <kashvijayperth@gmail.com>

---------

Co-authored-by: kash <kashvijayperth@gmail.com>
* Create docker-build-push.yml

* Actions workflow to build docker image and push to docker hub when pushed to main branch

---------

Co-authored-by: kash <kashvijayperth@gmail.com>
@initd1 initd1 changed the title Create docker-image.yml Docker integration using Github CI Actions Apr 15, 2023
@initd1 initd1 added the ci/cd Changes related to automation, workflow and CI/CD label Apr 15, 2023
@initd1
Copy link
Owner Author

initd1 commented Apr 15, 2023

CI/CD for docker integration completed and working.

Docker image built, and pushed successfully to dockerhub as evidenced by the checks on this PR.

Latest image in Dockerhub repository https://hub.docker.com/r/initd1/hackalert:

image

Future:
Potentially change the tag of the image being pushed to follow Semantic Versioning standard

@initd1 initd1 requested a review from H4ppy-04 April 15, 2023 17:20
Copy link
Collaborator

@H4ppy-04 H4ppy-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing it to something like CI or Docker Integration might be a better name. thoughts?

@initd1
Copy link
Owner Author

initd1 commented Apr 16, 2023

I think changing it to something like CI or Docker Integration might be a better name. thoughts?

Do you mean changing the name of the Github Action to Docker integration? or the docker image tag?

@H4ppy-04
Copy link
Collaborator

I was referring to the name of the GitHub action, as I thought that it might be more comprehensive.

@initd1
Copy link
Owner Author

initd1 commented Apr 16, 2023

I agree..I will change it to Docker integration

@initd1 initd1 merged commit bff840d into main Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Changes related to automation, workflow and CI/CD feature Addition of feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI/CD] Automated Build and Test Docker integration using Github CI Actions
2 participants