Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #38 implement unit test for config #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tejasrok007
Copy link

Unit Tests for the Config Module:

Wrote unit tests for the get_config function to verify:
Configuration files are properly parsed.
Environment variables override the configuration file values where applicable.
Ensuring Logging Configuration Works as Expected:

Developed tests for the get_logging_config function to ensure:
Proper error handling is in place for missing or invalid logging configuration files.
The logger is correctly configured using the logger.ini file in the Config directory.
Validation of the Logging Setup:

Added unit tests for configure_logging to check:
Creation of log directories and files, including the traceback.log.
Handlers for logging (both file and console) are correctly set up.
The correct log format and logging levels are applied based on the logger.ini configuration.
Testing Project Structure:

Set up a structured test file test_config.py to organize all unit tests within the project.
Ensured that the tests can be executed in the terminal using unittest or pytest frameworks.
Issue Verification:

Verified that the check_config_validity.py script runs without errors and properly validates the config files (assuming this script exists or was implied in the issue).
Issue Reference:
This task addresses the following issue:

#40: Implemented unit tests for the Config module, ensuring the configuration parsing, logging setup, and formatter behavior are correctly verified.
image
image

@tejasrok007 tejasrok007 requested a review from initd1 as a code owner October 9, 2024 05:11
@initd1
Copy link
Owner

initd1 commented Oct 9, 2024

Thanks for your contribution! Looks like the build check has failed.

@H4ppy-04
Copy link
Collaborator

H4ppy-04 commented Oct 16, 2024

Thanks @tejasrok007 for the PR, I'll have a look and see what I can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants