Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: uplift dependencies and implement revive #132

Closed
wants to merge 11 commits into from

Conversation

chungquantin
Copy link

@chungquantin chungquantin commented Jan 13, 2025

Required rustc version:

nightly-aarch64-apple-darwin (directory override for '/Users/chungquantin/Developer/drink/examples/flipper')
rustc 1.84.0-nightly (bc5cf994d 2024-11-05)

Before merging this PR, we need to make changes to the ink and polkadot-sdk dependencies to a right branch, currently those are pointed to these below branches:

CHANGELOG

  • examples/chain-extension: Current issue is the Memory trait in pallet-revive is required for the implementation of the chain extension but the Memory trait is in wasm module which is not exported as public. In the chain extension implementation of Pop Network, we forked the pallet-revive and modified it.
  • examples/contract-events: Tests passed ✅
  • examples/cross-contract-call-tracing:
Error: CallFailed(Module(ModuleError { index: 3, error: [10, 0, 0, 0], message: Some("ContractTrapped") }))
  • examples/dry-running: Tests passed ✅
  • examples/flipper: Tests passed ✅
  • examples/mocking: CodeRejected thrown because the DUMMY_CONTRACT is WASM blob code.
  • examples/multiple-contracts: Failed to compile the contract because psp22 dependency contract is not updated to revive.
  • examples/quick-start-with-drink: Tests passed ✅
  • examples/runtime-interaction: CodeRejected thrown because the CONTRACT is WASM blob code.

@pmikolajczyk41
Copy link
Member

hi, thank you very much for your work on drink, but at the moment we (i.e. original authors and maintainers) have no capacity nor possibilities to continue active work on this project, and it doesn't seem that this will change anytime soon; I think we should archive this repo and thus I propose that you create your own fork

@chungquantin chungquantin changed the title feat: uplifts sandbox and implements revive feat: uplift dependencies and implement revive Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants