Solve issue with EnhancedScript.prototype.findMissingMatchesInJSX only reporting parameter 't' as missing. Fixes #716 #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smukkejohan
changed the title
|
Also fixes #563 |
|
Hey @smukkejohan Oh, amazing job tracking down that bug! This was an old issue I was not able to identify. Great stuff. Not aware of the edge cases. I see a second PR, how would you want to approach merging processes for these two? |
|
This one should be able to merge regardless of the other one. I tested it
locally. I was just thinking that it might be nice while I was at it to
loose the dependency completely as I don't see a reason the native matchAll
shouldn't work, this is the other PR.
…On Thu, 2 Nov 2023, 18.51 Vladyslav Hrytsenko, ***@***.***> wrote:
Hey @smukkejohan <https://github.com/smukkejohan>
Oh, amazing job tracking down that bug! This was an old issue I was not
able to identify. Great stuff.
Not aware of the edge cases.
I see a second PR, how would you want to approach merging processes for
these two?
—
Reply to this email directly, view it on GitHub
<#934 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJO5GTCIIUZKUXRC52UZLYCPMRNAVCNFSM6AAAAAA62UN56SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJRGI2TQNRQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Awesome, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems this method is written with the expectation that matchAll (https://github.com/IonicaBizau/match-all/) is returning a nested array with capture groups. Maybe it has done before? Atleast it doesn't now. Using the native string.matchAll makes the remaining method work as expected printing warnings for the appropriate parameters that are accessed with NX.get but does not have values defined in the job.
Not sure if there are other places where the use of the matchAll package may be causing similar issues - did not test with anything else than parameters.
I could make a PR to replace all uses of match-all with native string.matchAll unless you are aware of some edge cases where the library is solving some issue - may be on certain platforms?