Solve issue with EnhancedScript.prototype.findMissingMatchesInJSX only reporting parameter 't' as missing. Fixes #716 #934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems this method is written with the expectation that matchAll (https://github.com/IonicaBizau/match-all/) is returning a nested array with capture groups. Maybe it has done before? Atleast it doesn't now. Using the native string.matchAll makes the remaining method work as expected printing warnings for the appropriate parameters that are accessed with NX.get but does not have values defined in the job.
Not sure if there are other places where the use of the matchAll package may be causing similar issues - did not test with anything else than parameters.
I could make a PR to replace all uses of match-all with native string.matchAll unless you are aware of some edge cases where the library is solving some issue - may be on certain platforms?