Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 206 with op: "StepNotFound" when no step found to run #701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpwilliams
Copy link
Member

Summary

If a step is intended to be run and was not found due to non-determinism or a changed function, still return a 206 with the "StepNotFound" opcode.

This complements inngest/inngest#1715 to ensure we recover from these situations gracefully.

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests
  • Added changesets if applicable

Related

@jpwilliams jpwilliams added the Bug Something isn't working label Sep 6, 2024
@jpwilliams jpwilliams self-assigned this Sep 6, 2024
Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: 0a1303b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working 📦 inngest Affects the `inngest` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants