fix(Grid): fixes data mutation in translateData utility

Closes #265
innovaccer · Aug 17, 2020 · 447d9b5 · 447d9b5
1 parent 58171e6
commit 447d9b5
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/core/components/organisms/grid/rowUtility.tsx b/core/components/organisms/grid/rowUtility.tsx
@@ -13,17 +13,14 @@ export const updateBatchData = (data: Data, rowIndexes: number[], dataUpdate: Pa
 };
 
 export function translateData(schema: ColumnSchema, data: RowData) {
-  let newData = data;
+  const newData = { ...data };
 
   if (schema.translate) {
     const translatedData = schema.translate(data);
-    newData = {
-      ...newData,
-      [schema.name]: typeof translatedData === 'object' ? {
-        ...newData[schema.name],
-        ...translatedData
-      } : translatedData
-    };
+    newData[schema.name] = (translatedData !== null && typeof translatedData === 'object') ? {
+      ...newData[schema.name],
+      ...translatedData
+    } : translatedData;
   }
   if (typeof newData[schema.name] !== 'object') newData[schema.name] = { title: newData[schema.name] };