chore(Modal, Sidesheet): removes unnecessary div wrapper

innovaccer · Jan 27, 2021 · 71847df · 71847df
1 parent b1bf4ad
commit 71847df
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 63 deletions.
diff --git a/core/components/molecules/dialog/__tests__/__snapshots__/Dialog.test.tsx.snap b/core/components/molecules/dialog/__tests__/__snapshots__/Dialog.test.tsx.snap
@@ -89,9 +89,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -106,9 +104,7 @@ exports[`Dialog component
 <body
   style="overflow: hidden;"
 >
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Modal-wrapper"
   >
@@ -289,9 +285,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -389,9 +383,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -489,9 +481,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -589,9 +579,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -689,9 +677,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -789,9 +775,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -889,9 +873,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -989,9 +971,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -1089,9 +1069,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -1189,9 +1167,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -1289,9 +1265,7 @@ exports[`Dialog component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"

diff --git a/core/components/molecules/modal/Modal.tsx b/core/components/molecules/modal/Modal.tsx
@@ -233,10 +233,10 @@ class Modal extends React.Component<ModalProps, ModalState> {
     );
 
     return (
-      <div>
+      <>
         {WrapperElement}
         <Backdrop open={this.state.open} />
-      </div>
+      </>
     );
   }
 }

diff --git a/core/components/molecules/modal/__tests__/__snapshots__/Modal.test.tsx.snap b/core/components/molecules/modal/__tests__/__snapshots__/Modal.test.tsx.snap
@@ -53,9 +53,7 @@ exports[`Modal component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -122,9 +120,7 @@ exports[`Modal component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -186,9 +182,7 @@ exports[`Modal component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -255,9 +249,7 @@ exports[`Modal component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"
@@ -272,9 +264,7 @@ exports[`Modal component
 <body
   style="overflow: hidden;"
 >
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Modal-wrapper"
   >
@@ -388,9 +378,7 @@ exports[`Modal component
       </div>
     </div>
   </div>
-  <div>
-    <div />
-  </div>
+  <div />
   <div
     class="Backdrop Backdrop--open Backdrop-animation--open"
     data-layer="true"

diff --git a/core/components/molecules/sidesheet/Sidesheet.tsx b/core/components/molecules/sidesheet/Sidesheet.tsx
@@ -227,10 +227,10 @@ class Sidesheet extends React.Component<SidesheetProps, SidesheetState> {
     );
 
     return (
-      <div>
+      <>
         {WrapperElement}
         <Backdrop open={this.state.open} />
-      </div>
+      </>
     );
   }
 }

diff --git a/core/utils/__tests__/__snapshots__/TS.test.tsx.snap b/core/utils/__tests__/__snapshots__/TS.test.tsx.snap
@@ -1481,8 +1481,6 @@ exports[`TS renders children 1`] = `
       Hello World!
     </span>
   </span>
-  <div />
-  <div />
   <div
     class="Modal-header"
     data-test="DesignSystem-ModalHeader"
-Original file line number
+Diff line change
@@ Expand Up @@
         );
         return (
-          <div>
+          <>
             {WrapperElement}
             <Backdrop open={this.state.open} />
-          </div>
+          </>
         );
       }
     }
@@ Expand Down @@