Skip to content

Commit

Permalink
chore(Table): adds overflow-hidden in Card wrapper
Browse files Browse the repository at this point in the history
  • Loading branch information
aditya-kumawat authored and satyamyadav committed Jan 27, 2021
1 parent 2eb8f5e commit 727f0fb
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 15 deletions.
2 changes: 1 addition & 1 deletion core/components/organisms/grid/__stories__/index.story.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export const all = () => {
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Grid
schema={applySchema ? schema : undefined}
data={applyData ? data : undefined}
Expand Down
2 changes: 1 addition & 1 deletion core/components/organisms/list/__stories__/index.story.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const all = () => {
// overflow: 'hidden'
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<List
{...dataAttr}
withHeader={withHeader}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const asyncTable = () => {
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
loaderSchema={loaderSchema}
fetchData={fetchData}
Expand Down Expand Up @@ -256,7 +256,7 @@ const customCode = `
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
loaderSchema={loaderSchema}
fetchData={fetchData}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export const all = () => {
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
key={`${async}`}
{...dataAttr}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const syncTable = () => {
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
loaderSchema={loaderSchema}
data={data}
Expand Down Expand Up @@ -151,7 +151,7 @@ const customCode = `
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
loaderSchema={loaderSchema}
data={data}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ const customCode = `
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
data={data}
schema={schema}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const syncLoaderSchema = () => {
// overflow: 'hidden'
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
loading={loading}
error={error}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const withEditableCell = () => {
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
loaderSchema={loaderSchema}
data={data}
Expand Down Expand Up @@ -159,7 +159,7 @@ const customCode = `
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
loaderSchema={loaderSchema}
data={data}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const customCode = `
height: '350px',
}}
>
<Card className="h-100">
<Card className="h-100 overflow-hidden">
<Table
schema={schema}
error={true}
Expand Down
2 changes: 0 additions & 2 deletions core/components/patterns/table/Table with Header/style.css
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
.Table-container {
display: flex;
height: 100%;
/* overflow: hidden; */
}

.Table-filters {
box-sizing: border-box;
display: flex;
flex-shrink: 0;
/* background: var(--secondary); */
}

.Table-filters--vertical {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ import './style.css';
return (
<div className="Table-container">
<div style={{ width: showVerticalFilters ? 'calc(100% - var(--spacing-9))' : '100%' }}>
<Card className="Table">
<Card className="Table overflow-hidden">
<div className="Table-header">
<Header
{...this.state}
Expand Down

0 comments on commit 727f0fb

Please sign in to comment.