Skip to content

Commit

Permalink
Fix errors
Browse files Browse the repository at this point in the history
  • Loading branch information
inokawa committed Nov 18, 2024
1 parent 65a219e commit 7d4adbf
Show file tree
Hide file tree
Showing 3 changed files with 60 additions and 130 deletions.
186 changes: 60 additions & 126 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions src/core/scroller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,6 @@ export const createScroller = (
export type WindowScroller = {
_observe(containerElement: HTMLElement): void;
_dispose(): void;
_scrollTo: (offset: number) => void;
_scrollBy: (offset: number) => void;
_scrollToIndex: (index: number, opts?: ScrollToIndexOpts) => void;
_fixScrollJump: () => void;
};
Expand Down
2 changes: 0 additions & 2 deletions src/react/WindowVirtualizer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,6 @@ export const WindowVirtualizer = forwardRef<
findEndIndex: store._findEndIndex,
getItemOffset: store._getItemOffset,
scrollToIndex: scroller._scrollToIndex,
scrollTo: scroller._scrollTo,
scrollBy: scroller._scrollBy,
};
}, []);

Check warning on line 238 in src/react/WindowVirtualizer.tsx

View workflow job for this annotation

GitHub Actions / check

React Hook useImperativeHandle has missing dependencies: 'scroller._scrollToIndex' and 'store'. Either include them or remove the dependency array

Expand Down

0 comments on commit 7d4adbf

Please sign in to comment.