Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue #105 #106

Closed
wants to merge 1 commit into from
Closed

fix Issue #105 #106

wants to merge 1 commit into from

Conversation

mbenabda
Copy link
Contributor

@mbenabda mbenabda commented Aug 8, 2013

No description provided.

@inossidabile
Copy link
Owner

Hello. What exactly does this solve? The error happens when rendering responder is unable to find one of expected map arguments. Shouldn't we rather throw proper exception in this case? In SOAP list or arguments if fixed unless otherwise specified. So if you declare a structure, it has to be complete during response.

@inossidabile
Copy link
Owner

@mbenabda ping?

@mbenabda
Copy link
Contributor Author

Hello,
In my opinion, raising an exception here isn't appropriate. Indeed, missing XML tags don't cause XML validation against a XSD to fail, but extra tags do. So I wouldn't throw an error on missing keys in the hash to render, but i would definitely throw one if there are extra undefined keys. What do you think ?

@mbenabda
Copy link
Contributor Author

Please reject the pull request as it's not fixing the problem completely

@inossidabile
Copy link
Owner

Here's the proper fix for the issue. Thanks for catching. I didn't realize before that the way we reconstruct missing fields actually differs between data types. It's no more. 0.8.2 is on the way.

@mbenabda
Copy link
Contributor Author

awesome ! thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants