bug(YouTube/SponsorBlock): applying the outline icon makes skip buttons overlap

[Rairof]

Type

Cosmetic

Tools used

RVX Manager

Application

YouTube v18.40.34

Bug description

Sponsorblock skip buttons on YouTube player gets overlapped when 2 or more segments are present.

Steps to reproduce

1. Patch youtube with sponsorblock patch
2. Watch a video having multiple segments marked on same timeline.

Relevant log output

N/A

Screenshots or videos

Solution

Seperate multiple skip buttons on top of another

Additional context

Using Xiaomi 11T pro

Device Environment

Android 13 MIUI 14.0.4

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.
• I have written the title and contents in English.
• This issue does not reproduce on unpatched YouTube or YT Music.

[inotia00]

please attach video url

[Rairof]

#1651 (comment)
https://youtu.be/FCR1i5oj8bk?si=Ev1_UbK4P6sBrx0I

[inotia00]

The issue seems to be reproduced only when using the Outline icon in the patch options

[inotia00]

@anddea, it seems to be an issue after the following PR: inotia00/revanced-patches#27

This issue does not occur in the default icon

[Rairof]

Oh okay. I can provide the .json of my settings if needed.

[anddea]

I can't reproduce this issue. Because there's no highlight segment for me in that video.

This problem occurs if highlight segment is enabled in Sponsorblock settings, and it shows skip to highlight and then overlaps it with skip any other segment when the seekbar reaches that segment.

I'm not on my computer to take a closer look but it seems to do with the same margin and aligning for sponsor and highlight buttons. For example, check difference on line 9 in these files, I think copying from default to outline (only line 9) will fix the issue:

Default
https://github.com/inotia00/revanced-patches/blob/revanced-extended/src/main/resources/youtube/sponsorblock/default/layout/inline_sponsor_overlay.xml

Outline
https://github.com/inotia00/revanced-patches/blob/revanced-extended/src/main/resources/youtube/sponsorblock/outline/layout/inline_sponsor_overlay.xml

and maybe some other corresponding files as well. If what I said doesn't work, then I will take a look when I'm free but otherwise default or outline icons shouldn't matter, only layout.

[inotia00]

fixed in revanced-patches-v2.196.1