Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion(YouTube/Shorts components): clarify the description of some settings #2357

Closed
5 tasks done
inotia00 opened this issue Sep 1, 2024 · 1 comment
Closed
5 tasks done
Labels
Suggestion Leave any other suggestions

Comments

@inotia00
Copy link
Owner

inotia00 commented Sep 1, 2024

Application

YouTube

Suggestion description

Setting Hide search suggestions in PreferenceScreen Shorts player hides the search suggestions button in the Shorts player

If the user accessed the Hide search suggestions setting via PreferenceScreen Shorts player, this would not be a big deal
(User knows which PreferenceScreen this setting belongs to)

PreferenceScreen_RVX

If the user accessed this setting by searching for the keyword Hide search suggestions in RVX settings, this could be a problem

Search_RVX

The user may not know which PreferenceScreen this setting belongs to, and may misunderstand that it hides the search suggestions in the YouTube search bar

Screenshot_2024-05-19-06-54-39-73_fe557b5c831afa8eecca413bd340ebe7.jpg

※ FYI: Hide trending searches setting was removed from the RVX patch as it no longer works properly

To avoid this misunderstanding, the description of the setting needs to be clarified

Example:
Hide location labelHide location button
Hide tagged productsHide tagged products button
Hide search suggestionsHide search suggestions button

Acknowledgements

  • This issue is not a duplicate of an existing suggestion.
  • This is not a feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@inotia00 inotia00 added the Suggestion Leave any other suggestions label Sep 1, 2024
inotia00 added a commit to inotia00/revanced-integrations that referenced this issue Sep 1, 2024
@inotia00
Copy link
Owner Author

inotia00 commented Sep 7, 2024

reflected in revanced-patches-4.13.1

@inotia00 inotia00 closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

1 participant