-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(YouTube/Alternative thumbnails): add alternative domain #60
Conversation
isn't it better to put an editable field, like for Sponsorblock, in order to support any host URL? |
Do you know other domains? I know about Piped, but it uses some hash thing in order for it to work, maybe you know some other domains? Because if we don't know other alternatives, maybe it's better without that additional editable option. Other than that, this feature works as expected. |
I don't know any others, it just seemed reasonable to me to put up a field like this if they had to change domain in the future, or if other people want to use a different domain, perhaps self-hosted. basically to make the patch a little more future-proof |
@KobeW50, I request a review of the string. Additional Context This PR adds a setting that fixes this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't review the Russian strings. If any of these suggestions are implemented, please reflect the changes for the Russian strings.
@KobeW50, It seems to me that everything is alright now. Also as a native russian, I can assure that russian strings correspond to english |
Co-authored-by: ILoveOpenSourceApplications <117499019+ILoveOpenSourceApplications@users.noreply.github.com>
in my opinion it is better to manage the presence, or non-presence, of prefixes at runtime |
@Francesco146, In the other hand modifying value(for the prefix remove) in runtime at overrideImageURL function in integrations isn't good, because it will removing prefix for every url again and again |
so I think that the way it is implemented now is quite optimal |
Thanks |
Added option to change original youtube images domain for users from countries, where it blocked
inotia00/revanced-integrations#48