Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube/Alternative thumbnails): add alternative domain #60

Merged
merged 4 commits into from
Jul 3, 2024
Merged

feat(YouTube/Alternative thumbnails): add alternative domain #60

merged 4 commits into from
Jul 3, 2024

Conversation

OLAF74
Copy link

@OLAF74 OLAF74 commented Jun 30, 2024

Added option to change original youtube images domain for users from countries, where it blocked

inotia00/revanced-integrations#48

@Francesco146
Copy link

isn't it better to put an editable field, like for Sponsorblock, in order to support any host URL?

@anddea
Copy link

anddea commented Jul 1, 2024

isn't it better to put an editable field, like for Sponsorblock, in order to support any host URL?

Do you know other domains? I know about Piped, but it uses some hash thing in order for it to work, maybe you know some other domains? Because if we don't know other alternatives, maybe it's better without that additional editable option.

Other than that, this feature works as expected.

@Francesco146
Copy link

I don't know any others, it just seemed reasonable to me to put up a field like this if they had to change domain in the future, or if other people want to use a different domain, perhaps self-hosted. basically to make the patch a little more future-proof

@inotia00
Copy link
Owner

inotia00 commented Jul 2, 2024

@KobeW50, I request a review of the string.

Additional Context
As far as I know, the yt3.ggpht.com domain is blocked in some regions, such as Russia.
(This means that in some regions, all images, including thumbnails, will not be fetched from the YouTube app without using a VPN)

This PR adds a setting that fixes this issue.

@inotia00 inotia00 requested a review from KobeW50 July 2, 2024 05:54
Copy link
Collaborator

@KobeW50 KobeW50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review the Russian strings. If any of these suggestions are implemented, please reflect the changes for the Russian strings.

@OLAF74
Copy link
Author

OLAF74 commented Jul 2, 2024

@KobeW50, It seems to me that everything is alright now. Also as a native russian, I can assure that russian strings correspond to english

Co-authored-by: ILoveOpenSourceApplications <117499019+ILoveOpenSourceApplications@users.noreply.github.com>
@Francesco146
Copy link

in my opinion it is better to manage the presence, or non-presence, of prefixes at runtime

@OLAF74
Copy link
Author

OLAF74 commented Jul 3, 2024

@Francesco146,
ResettableEditTextPreference which extends EditTextPreference has no way to modify value while saving.

In the other hand modifying value(for the prefix remove) in runtime at overrideImageURL function in integrations isn't good, because it will removing prefix for every url again and again

@OLAF74
Copy link
Author

OLAF74 commented Jul 3, 2024

so I think that the way it is implemented now is quite optimal

@inotia00 inotia00 changed the title DeArrow alternative domain feat(YouTube/Alternative thumbnails): add alternative domain Jul 3, 2024
@inotia00
Copy link
Owner

inotia00 commented Jul 3, 2024

Thanks

@inotia00 inotia00 merged commit e929edf into inotia00:dev Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants