Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to PHP 8.2 #108

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Default to PHP 8.2 #108

merged 7 commits into from
Oct 2, 2024

Conversation

tyrann0us
Copy link
Member

@tyrann0us tyrann0us commented Feb 6, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor

What is the current behavior? (You can also link to an open issue here)
All PHP-based reusable workflows default to PHP 8.0, which reached EOL on 2023-11-26.

What is the new behavior (if this is a feature change)?
Default all PHP-based reusable workflows to PHP 8.2, which will reach EOL on 2025-12-08.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes. All calling workflows not specifying a PHP version with the PHP_VERSION input will run on PHP 8.2, potentially causing the workflow to fail.

Other information:
Closes #44.

@tyrann0us tyrann0us added the on hold Pull requests that update a dependency file label Feb 13, 2024
@tyrann0us
Copy link
Member Author

On hold because WordPress only has "Beta" support for PHP 8.2

@tyrann0us tyrann0us mentioned this pull request Mar 21, 2024
3 tasks
@Chrico Chrico removed the request for review from luislard June 4, 2024 14:59
tyrann0us and others added 3 commits September 5, 2024 09:20
Signed-off-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
This was wrongly merged in one of the previous merges.
@tyrann0us tyrann0us removed the on hold Pull requests that update a dependency file label Sep 30, 2024
@tyrann0us
Copy link
Member Author

tyrann0us commented Sep 30, 2024

On hold because WordPress only has "Beta" support for PHP 8.2

WordPress 6.6 officially supports PHP 8.2; see https://make.wordpress.org/core/handbook/references/php-compatibility-and-wordpress-versions/. PR is no longer on hold.

Signed-off-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
@tyrann0us tyrann0us merged commit c55a8ba into main Oct 2, 2024
4 checks passed
@tyrann0us tyrann0us deleted the refactor/default-php-8-2 branch October 2, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: PHP 8.0 end of life November 2023
3 participants