-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/86 make token configurable via new secret GITHUB_USER_TOKEN #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I left a couple of comments. Also, I'm not a big fan of the USER_TOKEN
naming; what about WRITE_TOKEN
or similar?
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com> Signed-off-by: Luis Rosales <eng.luisrosales@gmail.com>
Co-authored-by: Erika Gili <e.gili@inpsyde.com> Signed-off-by: Luis Rosales <eng.luisrosales@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one last minor suggestion. Apart from that LGTM. Thanks for working on this! 🙏🏽
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com> Signed-off-by: Christian Leucht <3417446+Chrico@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍🏻
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Closes #86
Makes the token configurable so consumers are able to use specific user tokens to for example bypass some branch protection rules.
What is the current behavior? (You can also link to an open issue here)
Token is not configurable
What is the new behavior (if this is a feature change)?
The used token is configurable
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: