Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove didcomm module & update CI Script #9

Merged
merged 1 commit into from
Nov 28, 2023
Merged

build: remove didcomm module & update CI Script #9

merged 1 commit into from
Nov 28, 2023

Conversation

hamada147
Copy link
Contributor

@hamada147 hamada147 commented Nov 28, 2023 •
edited by jira bot
Loading

Overview

  • Remove DIDComm module
  • Update CI Script

ATL-6258
ATL-6257

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@hamada147
build: remove didcomm module & update CI Script
e7dcc74 
Signed-off-by: Ahmed Moussa <ahmed.moussa@iohk.io>
@hamada147 hamada147 self-assigned this Nov 28, 2023
@atala-dev
Copy link
Contributor

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 3 0 0.8s
✅ EDITORCONFIG editorconfig-checker 50 0 0.22s
✅ JSON eslint-plugin-jsonc 1 0 2.51s
✅ JSON jsonlint 1 0 0.23s
⚠️ JSON prettier 1 1 0.52s
✅ JSON v8r 1 0 2.55s
✅ KOTLIN ktlint 25 0 63.89s
⚠️ MARKDOWN markdownlint 5 49 1.33s
✅ MARKDOWN markdown-table-formatter 5 0 0.39s
✅ REPOSITORY devskim yes no 2.04s
✅ REPOSITORY dustilock yes no 0.05s
✅ REPOSITORY gitleaks yes no 0.34s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 20.73s
✅ REPOSITORY secretlint yes no 1.21s
✅ REPOSITORY syft yes no 0.25s
✅ REPOSITORY trivy yes no 6.25s
✅ REPOSITORY trivy-sbom yes no 1.57s
✅ XML xmllint 1 0 0.03s
⚠️ YAML prettier 7 1 0.86s
✅ YAML v8r 7 0 7.09s
✅ YAML yamllint 7 0 0.46s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@github-actions GitHub Actions
Copy link

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit e7dcc74.

cristianIOHK
cristianIOHK approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@cristianIOHK cristianIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hamada147 hamada147 merged commit ab7eb62 into main Nov 28, 2023
4 checks passed
@hamada147 hamada147 deleted the update/remove-didcomm-module branch November 28, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianIOHK cristianIOHK cristianIOHK approved these changes

@elribonazo elribonazo elribonazo approved these changes

@curtis-h curtis-h Awaiting requested review from curtis-h

@goncalo-frade-iohk goncalo-frade-iohk Awaiting requested review from goncalo-frade-iohk

Assignees

@hamada147 hamada147

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hamada147 @atala-dev @elribonazo @cristianIOHK