-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cardano-services): correctly load Mapper.withGovernanceActions #1438
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious about this not being caught in a test originally, and now the fix is being submitted without one. It's a hint things are a little disconnected. Can you justify the reason it's being submitted in isolation? Can @will-break-it not just pick this commit into his branch so it's submitted with more assurance we have a working system before merging to master?
packages/cardano-services/src/Projection/prepareTypeormProjection.ts
Outdated
Show resolved
Hide resolved
packages/cardano-services/src/Projection/prepareTypeormProjection.ts
Outdated
Show resolved
Hide resolved
0f386e4
to
855a057
Compare
OK, I can see this is just impacting code that arguably shouldn't even live in this SDK, and it would take an e2e test to cover. |
Context
While supporting @will-break-it on LW-10737 we realized about this issue.
Proposed Solution
Loaded the mapper.