Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log all queries #673

Merged
merged 1 commit into from
Apr 18, 2023
Merged

feat: log all queries #673

merged 1 commit into from
Apr 18, 2023

Conversation

mkazlauskas
Copy link
Member

@mkazlauskas mkazlauskas commented Mar 28, 2023

Context

Need to identify poorly performing queries

Proposed Solution

Add debug log

Important Changes Introduced

Also add missing return to SRV proxy

Copy link
Contributor

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log mechanism should be replicated in the original proxy, otherwise will not be available in deployed environments

iccicci
iccicci previously approved these changes Mar 28, 2023
Copy link
Contributor

@iccicci iccicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@mkazlauskas mkazlauskas force-pushed the feat/log-all-queries branch 2 times, most recently from bbced7c to c6877b3 Compare March 28, 2023 12:44
@mkazlauskas mkazlauskas requested a review from a team March 28, 2023 14:58
iccicci
iccicci previously approved these changes Mar 30, 2023
iccicci
iccicci previously approved these changes Mar 30, 2023
ivaylo-andonov
ivaylo-andonov previously approved these changes Mar 30, 2023
@rhyslbw rhyslbw merged commit 67bbe44 into master Apr 18, 2023
@rhyslbw rhyslbw deleted the feat/log-all-queries branch April 18, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants