-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: log all queries #673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccicci
reviewed
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The log mechanism should be replicated in the original proxy, otherwise will not be available in deployed environments
mkazlauskas
force-pushed
the
feat/log-all-queries
branch
from
March 28, 2023 10:34
d401592
to
dbd4aa5
Compare
iccicci
previously approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
mkazlauskas
force-pushed
the
feat/log-all-queries
branch
2 times, most recently
from
March 28, 2023 12:44
bbced7c
to
c6877b3
Compare
iccicci
previously approved these changes
Mar 30, 2023
mkazlauskas
force-pushed
the
feat/log-all-queries
branch
from
March 30, 2023 09:17
c6877b3
to
03980b1
Compare
iccicci
previously approved these changes
Mar 30, 2023
ivaylo-andonov
previously approved these changes
Mar 30, 2023
mkazlauskas
dismissed stale reviews from ivaylo-andonov and iccicci
via
March 31, 2023 05:42
3876b7f
mkazlauskas
force-pushed
the
feat/log-all-queries
branch
from
March 31, 2023 05:42
03980b1
to
3876b7f
Compare
rhyslbw
approved these changes
Apr 4, 2023
iccicci
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Need to identify poorly performing queries
Proposed Solution
Add debug log
Important Changes Introduced
Also add missing return to SRV proxy