Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cip 67 utils #767

Merged
merged 1 commit into from
Jun 16, 2023
Merged

feat: cip 67 utils #767

merged 1 commit into from
Jun 16, 2023

Conversation

lucas-barros
Copy link
Contributor

Context

Util functions to suppport CIP 67

Proposed Solution

Important Changes Introduced

@lucas-barros lucas-barros marked this pull request as ready for review June 13, 2023 22:04
packages/core/src/Asset/cip67.ts Outdated Show resolved Hide resolved
packages/core/src/Asset/cip67.ts Outdated Show resolved Hide resolved
@lucas-barros lucas-barros requested a review from mkazlauskas June 14, 2023 13:13
Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @lucas-barros. Really nice job with the isolated fixups and links left in context, this helps a lot with follow-up reviews 🙌

Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@rhyslbw rhyslbw merged commit 164be41 into master Jun 16, 2023
@rhyslbw rhyslbw deleted the feat/cip-67-utils branch June 16, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants