Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP cardano-ops as a library #378

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP cardano-ops as a library #378

wants to merge 2 commits into from

Conversation

deepfire
Copy link
Contributor

  1. make globals into a parameter
  2. allow definition of derived deployment shells

@deepfire deepfire marked this pull request as draft July 28, 2021 17:17
jonringer
jonringer reviewed Jul 28, 2021
View reviewed changes
nix/default.nix
pkgs:
if builtins.pathExists ../globals.nix
then import ../globals.nix pkgs
else builtins.trace "globals.nix missing, please add symlink" {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is supposed to stop evaluation, you probably want to use throw instead of trace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonringer, this is just code motion -- the original code did trace, not throw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepfire @jonringer