Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): Hero section - discovery page #1574

Merged
merged 11 commits into from
Jan 23, 2025
Merged

feat(cat-voices): Hero section - discovery page #1574

merged 11 commits into from
Jan 23, 2025

Conversation

LynxLynxx
Copy link
Contributor

@LynxLynxx LynxLynxx commented Jan 20, 2025 •
edited
Loading

Description

Creating a hero section widget with video as a background for discovery page. Should video assets be cache somewhere?

Related Issue(s)

Closes #1546

Description of Changes

  • adding new hero section widget
  • adding new types of assets videos

Should videos assets be somewhere cached?

Screenshots

Nagranie.z.ekranu.2025-01-20.o.19.35.02.mov

Related Pull Requests

Depends on #1551

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx self-assigned this Jan 20, 2025
@LynxLynxx LynxLynxx added review me PR is ready for review ux/ui UX/UI related issues F14 labels Jan 20, 2025
@LynxLynxx LynxLynxx marked this pull request as ready for review January 20, 2025 18:56
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@LynxLynxx LynxLynxx added the do not merge yet PR is not ready to be merged yet label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

damian-molinski

This comment was marked as resolved.

Sign in to view

@LynxLynxx LynxLynxx changed the base branch from main to feat/1551-discoveryLayout January 21, 2025 20:40
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@LynxLynxx LynxLynxx mentioned this pull request Jan 22, 2025
Merged
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@damian-molinski
Copy link
Contributor

Only two comments. Other then that looks good

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 405/405}$ | ${\color{red}Fail: 0/405}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 428/428}$ | ${\color{red}Fail: 0/428}$ |

damian-molinski
damian-molinski approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

❌ Test Report | ${\color{lightgreen}Pass: 425/429}$ | ${\color{red}Fail: 4/429}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

@LynxLynxx LynxLynxx merged commit bdcf702 into feat/1551-discoveryLayout Jan 23, 2025
42 checks passed
@LynxLynxx LynxLynxx deleted the feat/1546-hero-section branch January 23, 2025 16:49
LynxLynxx added a commit that referenced this pull request Jan 24, 2025
@LynxLynxx
feat(cat-voices): Discovery page layout (#1577)
88b52a6 
* feat: hero-section header

* feat: creating discovery page layout for f14

* fix: remove unused keys for widget

* feat: adding to proposalViewmodel isfavorite param

* chore: removing guard on proposals page

* feat(cat-voices):  Current campaign - Discovery Page (#1614)

* feat: making section hero widget more generic

* chore: remove unused file

* fix: typo

* feat: creating ui layout for current campaign

* feat: adding timeline card ui layout

* feat: adding idea journey

* fix: styling

* fix: formatting

* chore: making changes acording to reviews

* fix: styling

* chore: delete unused todos

* feat(cat-voices): Hero section - discovery page (#1574)

* feat: making section hero widget more generic

* chore: remove unused file

* fix: typo

* feat: adding didupdatewidget

* chore: moving init func to other widget

* fix: styling

* feat: adding _effectiveController

* fix: mounted check

* fix: formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damian-molinski damian-molinski damian-molinski approved these changes

@dtscalac dtscalac Awaiting requested review from dtscalac

Assignees

@LynxLynxx LynxLynxx

Labels
do not merge yet PR is not ready to be merged yet F14 review me PR is ready for review ux/ui UX/UI related issues
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Hero Section
2 participants
@LynxLynxx @damian-molinski