Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cat-voices): added x-icons to the schema template, aligned the json schema template with the F14 template document #1575

Merged
merged 19 commits into from
Jan 23, 2025
Merged

feat(cat-voices): added x-icons to the schema template, aligned the json schema template with the F14 template document #1575

merged 19 commits into from
Jan 23, 2025

Conversation

nathanbogale
Copy link
Contributor

Description

  • Added x-icon fields to section headings in the F14 proposal template schema to support icon display in the UI. Each icon path points to an SVG asset that represents the section's purpose.
  • Aligned the schema template with the F14 template document and design
  • Other minor fixes

Related Issue(s)

Closes #1535

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

nathanbogale and others added 10 commits January 14, 2025 16:48
@nathanbogale nathanbogale added review me PR is ready for review comment me Request for comments F14 labels Jan 21, 2025
@nathanbogale nathanbogale added this to the M4: Voting & Delegation milestone Jan 21, 2025
@nathanbogale nathanbogale self-assigned this Jan 21, 2025
dtscalac
dtscalac previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@dtscalac dtscalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtscalac dtscalac mentioned this pull request Jan 22, 2025
Merged
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 412/412}$ | ${\color{red}Fail: 0/412}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 428/428}$ | ${\color{red}Fail: 0/428}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 428/428}$ | ${\color{red}Fail: 0/428}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 428/428}$ | ${\color{red}Fail: 0/428}$ |

@minikin minikin enabled auto-merge (squash) January 23, 2025 15:37
@minikin minikin merged commit a7672e4 into main Jan 23, 2025
36 checks passed
@minikin minikin deleted the fix/proposal-remplate branch January 23, 2025 15:51
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 428/428}$ | ${\color{red}Fail: 0/428}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minikin minikin minikin approved these changes

@dtscalac dtscalac dtscalac left review comments

@stevenj stevenj Awaiting requested review from stevenj stevenj is a code owner

@neil-iohk neil-iohk Awaiting requested review from neil-iohk neil-iohk is a code owner

Assignees

@nathanbogale nathanbogale

Labels
comment me Request for comments F14 review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
M4: Voting & Delegation
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add x-icon fields to section headings
4 participants
@nathanbogale @minikin @dtscalac @stevenj