Cleanup legacy code and update cordova docs #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since it's unused and basically obsolete
Helps in the case the script was interrupted after deleting the plugin but before installing the new version. If there is an error it would most probably show up in the following install.
zeegomo
approved these changes
Jun 14, 2022
| @@ -1,723 +0,0 @@ | |||
| # Jörmungandr Wallet and Chain interactions | |||
There was a problem hiding this comment.
is this daedalus specific?
There was a problem hiding this comment.
not really, it's general documentation about the api at an abstract level and its integration with jormungandr, but it's completely out of date (it was written before even the first fund)... I think at this point it may as well be rewritten from scratch.
since the tests don't run, there is not much point in regenerating the assets, and not installing jcli could save some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up some legacy things that were still around mostly for the plugin:
The utxo conversion that we were using in the past, for all its variants. (rindex, bip44, free keys). I also removed the utxo_keys argument from the plugin API. This was already ignored internally, so this is mostly finishing that work, but it is a breaking change, so if preferred I can reintroduce a dummy argument to keep it compatible.
The daedalus paperwallet recovery support too. We never really used this.
I'm also removing the electron and browser cordova support, since both are out of date and unmaintained (and unused). Arguably, using
wallet-jsdirectly for those cases is better anyway, since it has a more idiomatic api.