fix: catch errors and inform user of the need to register voting rights [LW-11518] #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikGuzei
commented
Nov 12, 2024
| this.actions.dialogs.closeActiveDialog.trigger(); | ||
| this.sendMoneyRequest.reset(); | ||
| this.goToWalletRoute(wallet.id); | ||
| try { |
There was a problem hiding this comment.
Wrapping this in a try catch block was necessary because otherwise it crashed Daedalus … im not sure how it worked with other types of errors though 🤔
DominikGuzei
force-pushed
the
LW-11518-catch-errors-and-inform-user-of-the-need-to-register-voting-rights
branch
3 times, most recently
from
e0742c4
to
4bd3820
Compare
DominikGuzei
force-pushed
the
LW-11518-catch-errors-and-inform-user-of-the-need-to-register-voting-rights
branch
2 times, most recently
from
77dac74
to
c3a95a3
Compare
przemyslaw-wlodek
approved these changes
Nov 12, 2024
|
This PR needs to wait for #3229 to be merged (base branch) |
Base automatically changed from
chore/LW-11505-new-cardano-wallet
to
develop
November 20, 2024 08:33
DominikGuzei
changed the base branch from
develop
to
feat/LW-11519-governance-voting-tab
…tered voting rights yet [LW-11518] Signed-off-by: Dominik Guzei <dominik.guzei@gmail.com>
DominikGuzei
force-pushed
the
LW-11518-catch-errors-and-inform-user-of-the-need-to-register-voting-rights
branch
from
c3a95a3
to
58bcd21
Compare
|
@szymonmaslowski @szymonmaslowski I rebased this PR on |
szymonmaslowski
merged commit 235216a
into
feat/LW-11519-governance-voting-tab
5 checks passed
szymonmaslowski
deleted the
LW-11518-catch-errors-and-inform-user-of-the-need-to-register-voting-rights
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly handle the case when a Conway era wallet that has staking rewards but did not participate in governance (register voting rights) yet can't send transactions due to blocked staking rewards.
Please note: This PR is based on #3229 to work with the latest cardano-node and cardano-wallet which needs to be merged first.
Screenshots
Todos