Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vote delegation form #3273

Merged
merged 3 commits into from
Jan 29, 2025
Merged

fix: vote delegation form #3273

merged 3 commits into from
Jan 29, 2025

Conversation

szymonmaslowski
Copy link
Contributor

@szymonmaslowski szymonmaslowski commented Jan 27, 2025 •
edited
Loading

This PR

  • fixes the vote delegation form for wallets which had both: vote and pool delegation. With the recent Cardano Wallet update the form was not working properly for those wallets
  • enables HW based wallets to use cip129 drep format

hegaleon
hegaleon approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@hegaleon hegaleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear determination of script hash v id , using decoded hash to populate scriptHashHex and keyHashHex respectively

DominikGuzei
DominikGuzei approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch 👏

@michalrus michalrus merged commit 5472147 into release/7.1.0 Jan 29, 2025
5 checks passed
@michalrus michalrus deleted the fix/LW-12119-fix-vote-delegation-form branch January 29, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemyslaw-wlodek przemyslaw-wlodek przemyslaw-wlodek approved these changes

@hegaleon hegaleon hegaleon approved these changes

@DominikGuzei DominikGuzei DominikGuzei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szymonmaslowski @DominikGuzei @hegaleon @przemyslaw-wlodek @michalrus