Remove orphan Show instance for Foreign.C.Error.Errno
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadales
approved these changes
Apr 23, 2024
jorisdral
force-pushed
the
jdral/remove-show-errno
branch
from
1b2b01b
to
7ec9093
Compare
auto-merge was automatically disabled
April 23, 2024 14:22
Merge queue setting changed
This orphan instance largely exists to auto-derive a `Show` instance for `FsError`. Exposing an orphan instance for a type from `base` is not very nice, however. As such, we've removed the orphan instance, and we've written the `Show FsError` instance by hand. Note that this is a breaking change for both `fs-api` and `fs-sim`, since the orphan instance is propagated from `fs-api` through `fs-sim`.
jorisdral
force-pushed
the
jdral/remove-show-errno
branch
from
7ec9093
to
f4ea482
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #53