-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Generate a blake2b hash of a given binary buffer. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkioshn
added
enhancement
New feature or request
do not review yet
Do not review yet
draft
Draft
labels
Feb 8, 2024
bkioshn
requested review from
stevenj,
Mr-Leshiy,
FelipeRosa,
cong-or,
saibatizoku and
minikin
as code owners
February 8, 2024 07:57
bkioshn
changed the title
[WIP] feat(api): Generate a blake2b-256 hash of a given binary buffer.
[WIP] feat(util): Generate a blake2b-256 hash of a given binary buffer.
Feb 8, 2024
Mr-Leshiy
reviewed
Feb 8, 2024
Mr-Leshiy
requested changes
Feb 14, 2024
Mr-Leshiy
previously approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides few comments LGTM
stevenj
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
bkioshn
changed the title
feat(util): Generate a blake2b hash of a given binary buffer.
feat(api): Generate a blake2b hash of a given binary buffer.
Feb 15, 2024
bkioshn
removed
do not merge yet
PR is not ready to be merged yet
review me
PR is ready for review
labels
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate a blake2b hash of a given binary buffer.
Related function include
blake2b
blake2bmac
Related Issue(s)
Closes #98
Description of Changes
Reference to blake2b can be found rfc and doc
Fix how blake2 is implemented, since when blake2 is keyed it changes to MAC (Message Authentication Code) mode.
blake2b
andblake2bmac
blake2s
andblake2smac
blake2
withoutkey
will only accept bytes ofbuf
and optionaloutlen
which is the output length of the hash (eg. ifoutlen
= 32 the hash function is equal toblake2b-256
)blake2mac
accepts bytes ofbuf
, optionaloutlen
,key
, optionalsalt
, and optionalpersonal
If
outlen
is not specified, set to 64 which is blake2b-512blake2b
andblake2bmac
Please confirm the following checks