-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Implement Ed25519-BIP32 #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkioshn
requested review from
stevenj,
Mr-Leshiy,
FelipeRosa,
cong-or,
saibatizoku and
minikin
as code owners
February 15, 2024 08:27
bkioshn
changed the title
[WIP] feat(api): Implement Ed25519-BIP32
feat(api): Implement Ed25519-BIP32
Mar 18, 2024
apskhem
reviewed
Mar 18, 2024
apskhem
reviewed
Mar 18, 2024
apskhem
reviewed
Mar 18, 2024
apskhem
reviewed
Mar 18, 2024
apskhem
reviewed
Mar 18, 2024
FelipeRosa
reviewed
Mar 18, 2024
stevenj
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Ed25519-BIP32
Related Issue(s)
Closes #101
Description of Changes
Implementation of BIP39
Both of the implementations should support mnemonic in various languages including - English, Chinese-simplified, Chinese-traditional, Czech, French, Italian, Japanese, Korean, Spanish.
Implementation of BIP32-Ed25519
Cryptography State Management
Test vectors uses in this implementation
Please confirm the following checks