feat: WASM module package signing [part 2] #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and `Settings` JSON object. (#250) * refactor add wasm package config module * add SettingsSchema struct
* add certificate_and_keys section * add signature.md docs * fix spelling * wip * wip * fix * fix comments
* update sign cli command * add sign module * replace crypto oxide crate with RustCrypto crates * update * add keys module * add Certificate struct * wip * wip * add signature payload struct * wip * wip * wip * remove ununsed ed25519 dep * fix: bip39 doc --------- Co-authored-by: Joaquín Rosales <joaquin.rosales@iohk.io> Co-authored-by: bkioshn <bkioshn@gmail.com>
Mr-Leshiy
requested review from
stevenj,
FelipeRosa,
cong-or,
saibatizoku and
minikin
as code owners
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for contributing to the project!
Please fill out this template to help us review your changes.
Related Issue(s)
#249
Description of Changes
WasmModulePackage::signimplementationSignaturePayloadencoding/decoding.Signature.