-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cardano-chain-follower): Implementation #43
Conversation
d860deb
to
bf65a32
Compare
ce58da3
to
db18905
Compare
bf65a32
to
9a78d02
Compare
db18905
to
1f5233a
Compare
9a78d02
to
b4d42c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hermes/crates/cardano-chain-follower/examples/read_block_range.rs
Outdated
Show resolved
Hide resolved
29ccdb9
to
f85cb88
Compare
9ac0d60
to
6a1a451
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but need to correct conflicts now that earlier PR has merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove the Cargo.lock
This is also waiting on integration with the Mithril snapshot data, correct?
* feat(cardano-chain-follower): Split reader and follower and reader now supports reading single block and block ranges from Mithril snapshots * feat(cardano-chain-follower): Follower now uses request-response to communicate with its background task * feat(cardano-chain-follower): Follower reads blocks from Mithril snapshot (if configured) * chore(cardano-chain-follower): Cleanup traces and add missing docs * chore(cardano-chain-follower): Fix linter issues * chore(cardano-chain-follower): Fix formatting * chore(cardano-chain-follower): Fix spelling and cspell config * chore(cardano-chain-follower): Use pallas_hardano as a separate crate to avoid license issues * chore: Add cleanup comment to Cargo.toml * chore: Update CI files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds an implementation for cardano-chain-follower crate (defined in #33).
Reader
can be used to read blocks from the chain.Follower
should be used to follow chain updates.