Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: genesis values helper #80

Merged
merged 3 commits into from
Feb 5, 2024
Merged

feat: genesis values helper #80

merged 3 commits into from
Feb 5, 2024

Conversation

cong-or
Copy link
Contributor

@cong-or cong-or commented Feb 2, 2024

Helper to obtain genesis values which are required for block.epoch(genesis: &GenesisValues) which in my use case; is consumed from the gateway.

Gateway->Follower->Pallas.

When consuming via catalyst gateway and importing pallas and the follower to satisfy types, conflicts emerge. It is cleaner to just import the follower and add this helper method.

@cong-or cong-or changed the title Feature/genesis values helper feat(genesis values helper) Feb 2, 2024
@cong-or cong-or changed the title feat(genesis values helper) feat: genesis values helper Feb 2, 2024
FelipeRosa
FelipeRosa previously approved these changes Feb 2, 2024
Copy link

@FelipeRosa FelipeRosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cong-or cong-or merged commit ed80731 into main Feb 5, 2024
19 checks passed
@cong-or cong-or deleted the feature/genesis-values-helper branch February 5, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants