fix: [lw-11786] rely on network infor provider for connectivity issues #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
processReports: ✅ test report for 004e22c6
|
mchappell
approved these changes
Nov 4, 2024
| setNetworkConnection(isConnected ? NetworkConnectionStates.CONNNECTED : NetworkConnectionStates.OFFLINE); | ||
| let isNetworkInfoProviderConnected = true; | ||
| if (type === MessageTypes.NETWORK_INFO_PROVIDER_CONNECTION) { | ||
| isNetworkInfoProviderConnected = (data as HTTPConnectionStatus).connected; |
There was a problem hiding this comment.
can you type the structure so the as syntax isn't required?
vetalcore
force-pushed
the
fix/lw-11786-handle-network-errors
branch
2 times, most recently
from
2e4f624
to
eaddf0a
Compare
vetalcore
commented
Nov 5, 2024
apps/browser-extension-wallet/src/lib/scripts/background/providers.ts
Outdated
Show resolved
Hide resolved
vetalcore
force-pushed
the
fix/lw-11786-handle-network-errors
branch
3 times, most recently
from
249fe24
to
1b3c244
Compare
vetalcore
commented
Nov 7, 2024
vetalcore
force-pushed
the
fix/lw-11786-handle-network-errors
branch
from
1b3c244
to
004e22c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes