Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETCM-940] remove get transaction location from blockchain #1016

Merged

Conversation

AurelienRichez
Copy link
Contributor

@AurelienRichez AurelienRichez commented Jun 18, 2021

Description

This is part of the effort to simplify and reduce dependencies on blockchain. As a first small step, this removes getTransactionLocation which is used only once and other unused parameters.

Each commit is a small change so they can be reviewed separately (and reverted separately easily if there are not considered useful)

@AurelienRichez AurelienRichez force-pushed the refactor/ETCM-940-remove-getTransactionLocation branch 2 times, most recently from 5ff8d17 to 4b78f28 Compare June 18, 2021 07:28
@AurelienRichez AurelienRichez force-pushed the refactor/ETCM-940-remove-getTransactionLocation branch from 3b3e6c4 to 72255f5 Compare June 21, 2021 07:19
@AurelienRichez AurelienRichez merged commit f340fc5 into develop Jun 21, 2021
@AurelienRichez AurelienRichez deleted the refactor/ETCM-940-remove-getTransactionLocation branch June 21, 2021 07:59
krzysztofpaliga-iohk pushed a commit that referenced this pull request Jun 21, 2021
* remove unused blockchain parameters

* remove getTransactionLocation from blockchain

it is used only by EthTxService so EthTxService can directly use the storage

* remove getChainWeightByNumber as it is unused

* remove getStateStorage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants