[ETCM-522][ETCM-523] Apply scalafix scalafmt rules #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzajkowski
force-pushed
the
kaizen/apply-scalafix-scalafmt-rules
branch
from
119c260 to
eb07b45
Compare
dzajkowski
changed the title
dzajkowski
force-pushed
the
kaizen/apply-scalafix-scalafmt-rules
branch
from
eb07b45 to
79c622e
Compare
dzajkowski
changed the title
dzajkowski
force-pushed
the
kaizen/apply-scalafix-scalafmt-rules
branch
from
79c622e to
202f240
Compare
dzajkowski
force-pushed
the
kaizen/apply-scalafix-scalafmt-rules
branch
from
010474a to
bf8fd97
Compare
AnastasiiaL
reviewed
Jul 1, 2021
| @@ -63,18 +65,17 @@ object ECDSASignature { | |||
| val pointSign = chainId match { | |||
| case Some(id) if v == negativePointSign => (id * 2 + newNegativePointSign).toByte | |||
| case Some(id) if v == positivePointSign => (id * 2 + newPositivePointSign).toByte | |||
| case None => v | |||
| case _ => throw new IllegalStateException(s"Unexpected pointSign. ChainId: ${chainId}, v: ${v}") | |||
| case None => v | |||
There was a problem hiding this comment.
do we want that alignment? not sure it makes things prettier
dzajkowski
force-pushed
the
kaizen/apply-scalafix-scalafmt-rules
branch
from
af977df to
232ccde
Compare
dzajkowski
force-pushed
the
kaizen/apply-scalafix-scalafmt-rules
branch
from
232ccde to
52c71e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit introduces the new scala fix and fmt rules.
Second commit makes the checks on all modules mandatory on CI.
Fourth commit applies the rules to the codebase.