[ETCM-969] move best block and genesis functions to blockchain reader #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-bogastry
reviewed
Jul 6, 2021
| assert(peer1.blockchainReader.getBestBlock().get.hash == peer2.blockchainReader.getBestBlock().get.hash) | ||
| val peer1BestBlockNumber = peer1.blockchainReader.getBestBlock().get.number | ||
| val peer2BestBlockNumber = peer2.blockchainReader.getBestBlock().get.number | ||
| assert(peer1BestBlockNumber == peer2BestBlockNumber && peer1BestBlockNumber == length) |
leo-bogastry
approved these changes
Jul 6, 2021
AnastasiiaL
reviewed
Jul 6, 2021
src/main/scala/io/iohk/ethereum/testmode/TestModeComponentsProvider.scala
Outdated
Show resolved
Hide resolved
AnastasiiaL
approved these changes
Jul 6, 2021
AurelienRichez
force-pushed
the
refactor/ETCM-969-move-getBestBlock
branch
from
45bfb31 to
d123b39
Compare
AurelienRichez
force-pushed
the
refactor/ETCM-969-move-getBestBlock
branch
from
d123b39 to
fbf9ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorry for the long PR. This PR is a prerequisite for ETCM-969. It moves some part of blockchain to the BlockchainReader and I will open a second PR will use that to create a "blockchain instance" interface.
The changes are :
getBestBlockandgetBestBlockNumbertoBlockchainReaderBlockchainReaderIt also has a common part with #1035 regarding blockchain metadata. I kept the same naming so that the conflict are easy to fix if any.