-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ETCM-921] Add optional access lists to transactions #1040
Conversation
e7d3aaf
to
42ac0e0
Compare
} | ||
} | ||
|
||
case class TransactionWithAccessList( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this by any chance simply be a Transaction
? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would collide with trait Transaction
. or do you have a good name for the base one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TransactionBase
maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the deal with typed transactions is that there will be more of them. this one is just the first. I could name it TypedTransaction01
.
02 has already been proposed and is being adapted afaik
This is the first PR to allow bodies to contain TypedTransactions and LegacyTransactions at the same time (Magneto HF).
It renames the base transaction type, introduces the TransactionWithAccessList class and fixes unit tests.
More to come.