[ETCM-25/26] enable byzantium and constantinople on atlantis/agharta #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonradStaniec
force-pushed
the
etcm-25-enable-features
branch
from
2560382 to
6a7e74c
Compare
mmrozek
approved these changes
Aug 25, 2020
| @@ -131,14 +131,24 @@ class VM[W <: WorldStateProxy[W, S], S <: Storage[S]] extends Logger { | |||
| private def invalidCallResult(context: PC): PR = | |||
| ProgramResult(ByteString.empty, context.startGas, context.world, Set(), Nil, Nil, 0, Some(InvalidCall)) | |||
|
|
|||
|
|
|||
| private def exceedsMaxContractSize(context: PC, config: EvmConfig, contractCode: ByteString): Boolean = { | |||
| val maxCodeSizeExceeded = config.maxCodeSize.exists(codeSizeLimit => contractCode.size > codeSizeLimit) | |||
There was a problem hiding this comment.
Very minor - it could be lazy. We don't need to check it if we are before the fork
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.