Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETCM-21] EIP-2028: Transaction data gas cost reduction #647

Merged
merged 2 commits into from
Aug 27, 2020
Merged

[ETCM-21] EIP-2028: Transaction data gas cost reduction #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffd03f8
[ETCM-21] EIP-2028: Transaction data gas cost reduction
mmrozek Aug 26, 2020
d2626ae
[ETCM-21] Fix test
mmrozek Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/scala/io/iohk/ethereum/vm/EvmConfig.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ object FeeSchedule {
class PhoenixFeeSchedule extends AghartaFeeSchedule{
override val G_sload: BigInt = 800
override val G_balance: BigInt = 700
override val G_txdatanonzero = 16
}

}
Expand Down
6 changes: 3 additions & 3 deletions src/test/scala/io/iohk/ethereum/ledger/StxLedgerSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ class StxLedgerSpec extends FlatSpec with Matchers with Logger {

"StxLedger" should "correctly estimate minimum gasLimit to run transaction which throws" in new ScenarioSetup {
/**
* Transaction requires gasLimit equal to 122397, but actual gas used due to refund is equal 42907.
* Our simulateTransaction properly estimates gas usage to 42907, but requires at least 122397 gas to
* Transaction requires gasLimit equal to 121825, but actual gas used due to refund is equal 42907.
* Our simulateTransaction properly estimates gas usage to 42907, but requires at least 121825 gas to
* make that simulation
*
* After some investigation it seems that semantics required from estimateGas is that it should return
Expand Down Expand Up @@ -174,7 +174,7 @@ trait ScenarioSetup extends EphemBlockchainTestSetup {
val someGenesisBlock: Array[Byte] =
Hex.decode("f901fcf901f7a00000000000000000000000000000000000000000000000000000000000000000a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347948888f1f195afa192cfee860698584c030f4c9db1a07dba07d6b448a186e9612e5f737d1c909dce473e53199901a302c00646d523c1a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421b90100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008302000080832fefd8808454c98c8142a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421880102030405060708c0c0")

val minGasLimitRequiredForFailingTransaction: BigInt = 122397
val minGasLimitRequiredForFailingTransaction: BigInt = 121825

val block: Block = someGenesisBlock.toBlock
val genesisBlock: Block =
Expand Down