[Chore] Project build updates #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkoAlic
force-pushed
the
chore/update-sbt
branch
from
2eca73b to
e1c81f2
Compare
kapke
reviewed
Sep 10, 2020
build.sbt
Outdated
| version := "2.0", | ||
| scalaVersion := "2.12.5", | ||
| version := "3.0", | ||
| scalaVersion := "2.12.10", |
kapke
reviewed
Sep 10, 2020
build.sbt
Outdated
| executableScriptName := name.value, | ||
| dist in Universal := ((dist in Universal) dependsOn verify).value | ||
| dist in Universal := (dist in Universal).value |
kapke
reviewed
Sep 10, 2020
project/build.properties
Outdated
| sbt.version = 1.2.8 |
There was a problem hiding this comment.
We don't rely on anything fancy here, is 1.3 feasible then?
There was a problem hiding this comment.
with 1.3.13:
# Unit tests step
[info] Compiling 143 Scala sources to /home/circleci/project/target/scala-2.12/test-classes ...
/usr/share/sbt/bin/sbt-launch-lib.bash: line 58: 789 Killed "$@"
^ i tried to increase memory but it doesn't worked, so i decided to turn back to 1.2.8
There was a problem hiding this comment.
👍
Did you update your sbt launcher script as well? It has changed a bit between 1.2.x and 1.3 to accomodate for specifically different approach to memory.
- Update Sbt - Update Scala - Remove sbt-verify package: In the near future will covered by nix build
mirkoAlic
force-pushed
the
chore/update-sbt
branch
from
e1c81f2 to
8e97c4e
Compare
mirkoAlic
force-pushed
the
chore/update-sbt
branch
from
2e20baf to
62fe08a
Compare
mirkoAlic
force-pushed
the
chore/update-sbt
branch
from
c556e14 to
4354d7b
Compare
mirkoAlic
force-pushed
the
chore/update-sbt
branch
from
b409548 to
8a47143
Compare
kapke
reviewed
Sep 14, 2020
.circleci/config.yml
Outdated
| @@ -2,7 +2,7 @@ version: 2 | |||
| jobs: | |||
| build: | |||
| environment: | |||
| - SBT: "sbt -v -mem 1024" | |||
| - SBT: "sbt -v -mem 2048 -J-Xmx4g -J-Xss10M" | |||
There was a problem hiding this comment.
setting -mem and -Xmx is redundant
| @@ -1 +1 @@ | |||
| -Dconfig.file=./conf/rpc-test-private.conf -Dlogback.configurationFile=./conf/rpc-test-logback.xml -J-Xss10M | |||
| -Dconfig.file=./conf/rpc-test-private.conf -Dlogback.configurationFile=./conf/rpc-test-logback.xml -J-Xmx4g -J-Xss10M | |||
There was a problem hiding this comment.
MAntis should be more than fine with 2g of memory with disabled mining. Do we really want to hardcode that value here and not on deployment side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the catching up, the goal of this PR is to prepare the build for better supporting of the nix build.
Important Changes Introduced
Testing
Crucial components should continue working: CircleCi, local build, etc, etc.