Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Update akka version #662

Merged
merged 3 commits into from
Sep 14, 2020
Merged

[CHORE] Update akka version #662

merged 3 commits into from
Sep 14, 2020

Conversation

mmrozek
Copy link
Contributor

@mmrozek mmrozek commented Sep 10, 2020 •
edited
Loading

Description

Update akka versions:

  • akka - v2.6.9
  • akka http - v10.2.0

@ntallar
Copy link

ntallar commented Sep 10, 2020

Should we go the step further and update to 2.6.X?

For me yes, it's doesn't seem to require that many more changes and I don't see any reason for not doing it

(apart from that current changes LGTM)

ntallar
ntallar approved these changes Sep 11, 2020
View reviewed changes
Copy link

@ntallar ntallar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 .\\            //.
. \ \          / /.
.\  ,\     /` /,.-
 -.   \  /'/ /  .
 ` -   `-'  \  -
   '.       /.\`
      -    .-
      :`//.'
      .`.'
      .' BP

@mirkoAlic mirkoAlic merged commit 399730b into develop Sep 14, 2020
@mirkoAlic mirkoAlic deleted the update-akka branch September 14, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntallar ntallar ntallar approved these changes

@mirkoAlic mirkoAlic Awaiting requested review from mirkoAlic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmrozek @ntallar @mirkoAlic @jmendiola222