[ETCM-110] Add eth_chainId RPC method #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapke
force-pushed
the
etcm-110-eth_chainid_rpc-method
branch
from
da5d362 to
749f5fe
Compare
mmrozek
approved these changes
Sep 21, 2020
| implicit val eth_chainId = new JsonDecoder[ChainIdRequest] with JsonEncoder[ChainIdResponse] { | ||
| def decodeJson(params: Option[JArray]) = params match { | ||
| case None | Some(JArray(Nil)) => Right(ChainIdRequest()) | ||
| case other => Left(InvalidParams("eth_chainId method does not take params")) |
There was a problem hiding this comment.
I realized that other parameterless methods don't check if params is empty. Maybe we could improve that in this PR. WDYT?
There was a problem hiding this comment.
If only @pslaski agrees (this will result in quite huge PR due to formatting)
There was a problem hiding this comment.
this PR is already huge so go for it ;)
kapke
force-pushed
the
etcm-110-eth_chainid_rpc-method
branch
2 times, most recently
from
1d59a1f to
d7fa62c
Compare
pslaski
approved these changes
Sep 23, 2020
| @@ -23,11 +25,32 @@ object JsonRpcController { | |||
| trait JsonDecoder[T] { | |||
| def decodeJson(params: Option[JArray]): Either[JsonRpcError, T] | |||
| } | |||
| object JsonDecoder { | |||
| abstract class NoParamsDecoder[T](request: => T) extends JsonDecoder[T] { | |||
kapke
force-pushed
the
etcm-110-eth_chainid_rpc-method
branch
from
d7fa62c to
8f34a23
Compare
|
@pslaski From what I've checked there usually are such tests for happy path and I think it's enough since the behavior is uniform now across whole RPC API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to Ethereum RPC Spec, Mantis lacks
eth_chainIdmethod, which makes it much harder to issue transactions from Luna.PS. This PR got so big due to auto-formatting. Changes crucial for this task are really minimal (test for eth service, test for rpc controller, insomnia entry, controller entry, json codec, eth service method).
Testing
eth_chainIdin Insomnia should return configured value in hex format according to spec (https://playground.open-rpc.org/?schemaUrl=https://raw.githubusercontent.com/etclabscore/ethereum-json-rpc-specification/master/openrpc.json&uiSchema%5BappBar%5D%5Bui:input%5D=false)