EthService performance fix for AtomicReference update loops #775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updateAndGet()
method used to remove obsolete hashes containsdo{ map.filter() } while()
nested loop and has overall O(n^2) complexity.mapValues
should be avoided as its memory issue is fixed only in scala 2.13. Also, one shouldn't use mapValues if only values needed.AtomicReference
is redundant, becausecompareAndSet
-based method result (in p.1) is not used in code.Proposed Solution
Remove
updateAndGet
to save CPU cycles, removeAtomicReference
since all the changes inTrieMap
are atomic.Introduce
TrieMap
to handle concurrent writes and save memory spent onMap
instances, that were created on eachhashRate
read request (with obsolete elements)