Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] enable discovery on sagano testnet #846

Merged
merged 1 commit into from
Dec 9, 2020
Merged

[FIX] enable discovery on sagano testnet #846

merged 1 commit into from
Dec 9, 2020

Conversation

KonradStaniec
Copy link
Contributor

Description

Enables discovery for users node on sagano testnet

@KonradStaniec KonradStaniec requested review from aakoshh and a user December 9, 2020 15:41
@aakoshh
Copy link
Contributor

aakoshh commented Dec 9, 2020 •
edited
Loading

So base-testnet.conf doesn't need to be overridden in testnet-internal-nomad.conf?

@KonradStaniec
Copy link
Contributor Author

So as i understand i could either:

  • override it in "testnet-internal-nomad
  • or modify in base-testnet

the other places where base-testnet is used is gac-testnet, but from what i known this won't be used, so i can directly change it in base-testnet.conf

ghost
ghost approved these changes Dec 9, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aakoshh
Copy link
Contributor

aakoshh commented Dec 9, 2020

It seems logical to override it in testnet-internal-nomad.conf, at least that's what I thought you did based on the title.

@KonradStaniec
Copy link
Contributor Author

sure, i can go that way if it seems more logical at first sight 👍

@KonradStaniec KonradStaniec force-pushed the fix/discovery-config-sagano-testnet branch from 2c5f12c to 1696e19 Compare December 9, 2020 15:52
@KonradStaniec KonradStaniec merged commit 1696e19 into develop Dec 9, 2020
@jmendiola222 jmendiola222 added the high priority This PRs should be reviewed and merged ASAP label Dec 9, 2020
@dzajkowski dzajkowski deleted the fix/discovery-config-sagano-testnet branch April 9, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakoshh aakoshh aakoshh approved these changes

Assignees
No one assigned
Labels
high priority This PRs should be reviewed and merged ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KonradStaniec @aakoshh @jmendiola222