-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include PPoW info in BlockResponse #867
Conversation
@@ -61,6 +68,17 @@ object BlockResponse { | |||
|
|||
val (lcn, td) = weight.map(_.asTuple).separate | |||
|
|||
val signature = | |||
if (block.header.extraData.length >= ECDSASignature.EncodedLength) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment, when we have the condition (block.header.extraData.length = ECDSASignature.EncodedLength)
The following line:
block.header.extraData.takeRight(ECDSASignature.EncodedLength) is not required, right?
Anyway, this code is clear and understandable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Continuing from #841